This is the mail archive of the
cygwin
mailing list for the Cygwin project.
Re: Crash in g_file_monitor on 32-bit Cygwin
- From: Yaakov Selkowitz <yselkowitz at cygwin dot com>
- To: cygwin at cygwin dot com
- Date: Tue, 14 Oct 2014 16:09:33 -0500
- Subject: Re: Crash in g_file_monitor on 32-bit Cygwin
- Authentication-results: sourceware.org; auth=none
- References: <53AB82AB dot 5000304 at cornell dot edu> <53ADA5B5 dot 10404 at cornell dot edu> <53ADAF68 dot 2020703 at cygwin dot com> <53AEA23A dot 8030306 at cornell dot edu> <543D4ED3 dot 6020605 at cornell dot edu> <543D6BB9 dot 3030009 at cornell dot edu> <20141014192803 dot GE2681 at calimero dot vinschen dot de>
On 2014-10-14 14:28, Corinna Vinschen wrote:
I know the code is not yours, but I have to vent while I see this code :)
Actually, this isn't the first time you're seeing this code, it's just
been a while. :-)
There's no reason to load GetVolumePathName from kernel32 since all supported
platforms provide this entry point.
They didn't when this code was written.
How old is this code?
2006.
What *exactly* is this function trying to check?
gamin enforces permissions on its sockets, which will fail on FAT
partitions for obvious reasons, so we need to bypass those checks in
that case.
Obviously this code is overdue for an update, which I'll try to do later
today.
Yaakov
--
Problem reports: http://cygwin.com/problems.html
FAQ: http://cygwin.com/faq/
Documentation: http://cygwin.com/docs.html
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple