This is the mail archive of the
cygwin
mailing list for the Cygwin project.
Re: MSYS mode (continue)
- From: Alexey Pavlov <alexpux at gmail dot com>
- To: cygwin at cygwin dot com
- Date: Thu, 4 Jul 2013 13:07:01 +0400
- Subject: Re: MSYS mode (continue)
- References: <CABEPuQ+jEFJEQt=MGyn5m7Q+Ccs5A-i7vkk0McM=yyoCOw+Kgw at mail dot gmail dot com> <20130703181504 dot GA3182 at ednor dot casa dot cgf dot cx> <CABEPuQLW+TQ5VUVSYrCOzQ4Y5fdHNp=ymcb9r+xV7ROyYS=OBA at mail dot gmail dot com> <20130703195020 dot GC1705 at calimero dot vinschen dot de> <51D49188 dot 7000708 at cwilson dot fastmail dot fm> <20130703215716 dot GA1752 at ednor dot casa dot cgf dot cx> <51D4A7F4 dot 80507 at cwilson dot fastmail dot fm> <CABEPuQJ6V55nLo1hHO=xxAjjxsV5ahAuHj-jfWH-=Hk_hmk-eA at mail dot gmail dot com> <20130704085847 dot GK5118 at calimero dot vinschen dot de>
2013/7/4 Corinna Vinschen:
> Hi Alexey,
>
> On Jul 4 06:33, Alexey Pavlov wrote:
>> My opinion is to extend Cygwin parser to read msys-like mounts. It's
>> very simple:
>>
>> --- mount.cc 2013-04-24 20:29:29.000000000 +0400
>> +++ Cygwin/winsup/cygwin/mount.cc 2013-06-13 09:35:01.479492100 +0400
>> @@ -1125,8 +1118,17 @@
>> if (!*c)
>> return true;
>> cend = find_ws (c);
>> - *cend = '\0';
>> posix_path = conv_fstab_spaces (c);
>> + if (!*cend)
>> + {
>> + unsigned mount_flags = MOUNT_SYSTEM | MOUNT_BINARY |
>> MOUNT_NOPOSIX | MOUNT_NOACL;
>> +
>> + int res = mount_table->add_item (native_path, posix_path, mount_flags);
>> + if (res && get_errno () == EMFILE)
>> + return false;
>> + return true;
>> + }
>> + *cend = '\0';
>> /* Third field: FS type. */
>> c = skip_ws (cend + 1);
>> if (!*c)
>
> This patch is trivial enough to go in (barring discussion) without
> copyright assignment. Still, the CA is necessary for more complex
> patches.
>
Good.
> Would you mind to send a CA (http://cygwin.com/assign.txt) per snail
> mail to the address given in the form?
>
I will do it in a week I think.
> Apart from that, please provide a ChangeLog entry. Please read
> http://cygwin.com/contrib.html, especially the last section called
> "When you have finalized your changes".
>
Ok.
>
> Thanks,
> Corinna
>
> --
> Corinna Vinschen Please, send mails regarding Cygwin to
> Cygwin Maintainer cygwin AT cygwin DOT com
> Red Hat
>
> --
> Problem reports: http://cygwin.com/problems.html
> FAQ: http://cygwin.com/faq/
> Documentation: http://cygwin.com/docs.html
> Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
>
--
Problem reports: http://cygwin.com/problems.html
FAQ: http://cygwin.com/faq/
Documentation: http://cygwin.com/docs.html
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple