This is the mail archive of the cygwin mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: csih: Patch getVolInfo.c


On Jul 23 10:03, Corinna Vinschen wrote:
> On Jul 22 19:54, Eric Blake wrote:
> > Corinna Vinschen <corinna-cygwin <at> cygwin.com> writes:
> > 
> > > > However, for access to the filesystem information, the READ_CONTROL
> > > > isn't necessary.  A desired access of 0 is sufficient in every case
> > > > I could lay my hands on (NTFS, NFS, Samba, FAT32, HGFS).
> > > > 
> > > along these lines, can you please test the change to mount.cc on MVFS?
> > 
> > Seeing as how you aren't in a position to lay your hands on MVFS, I get to be 
> > the bearer of bad news.
> > 
> > You'll have to recode this to do a retry loop, since MVFS rejects NtOpenFile 
> > with access of 0, giving status 0xc0000022.  The only question now is whether 
> > you should do the READ_CONTROL first and retry to 0, or 0 first and 
> > READ_CONTROL as the retry.
> > 
> > > It would be a pity if MVFS would be broken again due to this change,
> > > after having gone through all the hassle of the last days.
> > 
> > And of course, with 'df -T mvfs/file' now showing "unknown" instead of "mvfs", 
> > you can imagine what else broke.
> 
> Ok, I reverted the change and now, if opening with READ_CONTROL fails,
> I try with FILE_READ_DATA, just like GetVolumeInformation.  That should
> really do it once and for all(*).

(*) Famous last words...


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]