This is the mail archive of the cygwin mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [1.7][BUG] winsup/cygwin/strfuncs.cc

On Jun  4 03:11, IWAMURO Motonori wrote:
> Hi.
> 
> I found a trivial bug.
> 
> *pmbs is unsigned char.
> '\x80' is -128 because it is char literal (not unsigned char).
> -> "*pmbs > '\x80'" is always true.
> 
> # Is not "> 0x80" but ">= 0x80" correct?

You're right.  I meant to fix that when I applied the previous patch
but then missed it.  I applied the ">= 0x80" condition.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]