This is the mail archive of the
cygwin
mailing list for the Cygwin project.
Re: 1.5.19: pdksh 5.2.14-3 tab-complete and shell metacharacters
On Mon, 30 Jan 2006, Svend Sorensen wrote:
> On 1/30/06, Igor Peshansky <pechtcha@XX.XXX.XXX> wrote:
Again, <http://cygwin.com/acronyms/#PCYMTNQREAIYR>. Thanks.
> > Ugh, top-posting... Reformatted.
> >
> > On Mon, 30 Jan 2006, Svend Sorensen wrote:
> >
> > > On 1/30/06, Igor Peshansky <pechtcha@XX.XXX.XXX> wrote:
> >
> > <http://cygwin.com/acronyms/#PCYMTNQREAIYR>. Thanks.
> >
> > > > On Thu, 26 Jan 2006, Svend Sorensen wrote:
> > > >
> > > > > When I use pdksh to expand the name of a file with spaces or
> > > > > other shell metachars in it, the filename is expanded without
> > > > > escaping the metacharacters.
> > > >
> > > > Thanks for the report. I've been able to reproduce this.
> > > > There's an upstream patch that fixes the issue, and I'm currently
> > > > working on integrating that and other patches into the build to
> > > > produce a new release (but no ETA yet).
> > > >
> > > > > The pdksh version strings are identical.
> > > >
> > > > This is unfortunate. What is the patchlevel shown for the pdksh
> > > > package on NetBSD?
> > > >
> > > > FWIW, I will include the full list of patches in the README for
> > > > the new release.
> > >
> > > The NetBSD system I tested has pdksh-5.2.14nb1 installed. There are
> > > two patches in pkgsrc, one which removes a Makefile check for pdksh
> > > in the /etc/shells file, and one which removes a declaration of
> > > errorno. Other than that, it uses the vanilla pdksh-5.2.14.tar.gz
> > > sources.
> >
> > Hmm, this is extremely surprising, as 5.2.14 doesn't contain any code
> > to quote shell metacharacters on tab completion. Are you sure those
> > are vanilla sources? I know OpenBSD uses its own CVS repository for
> > PDKSH -- does NetBSD do this too? Can you compare the tarball with
> > <ftp://ftp.cs.mun.ca/pub/pdksh/pdksh-5.2.14.tar.gz>?
>
> It turns out I was running NetBSD's base ksh, which must be a patched
> pdksh.
Ah, I thought so.
> I tested the version of pdksh in pkgsrc, and it has no metacharacter
> expansion. The pkgsrc version of pdksh uses that source tarball you
> mentioned.
Right. If you could get a pointer at the NetBSD CVS repository for pdksh,
or at least a list of NetBSD-specific patches on top of the base sources,
that would be great.
> > > I have attached the patches from pkgsrc.
> >
> > These patches don't seem to do anything interesting.
> >
> > The next release of PDKSH on Cygwin will be built with a metacharacter
> > quoting patch (from Debian). I'd still like to investigate this to
> > see why it works for you on NetBSD without that patch...
>
> NetBSD must patch their stock pdksh, which would make this a feature
> request, not a bug report.
Nevertheless, I've been meaning to add upstream patches for a while...
They address some very nasty bugs in the vanilla sources.
> Should NetBSD modify their base KSH_VERSION reporting to show it is
> patched?
I'd say yes, if only to avoid the confusion you had at the start of this
thread (with the identical version numbers).
> Thanks for your help, Igor.
Don't thank me yet -- you'll probably be one of the people testing the new
release. :-)
Igor
--
http://cs.nyu.edu/~pechtcha/
|\ _,,,---,,_ pechtcha@cs.nyu.edu | igor@watson.ibm.com
ZZZzz /,`.-'`' -. ;-;;,_ Igor Peshansky, Ph.D. (name changed!)
|,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
"Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte."
"But no -- you are no fool; you call yourself a fool, there's proof enough in
that!" -- Rostand, "Cyrano de Bergerac"
--
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Problem reports: http://cygwin.com/problems.html
Documentation: http://cygwin.com/docs.html
FAQ: http://cygwin.com/faq/