This is the mail archive of the cygwin@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [avail for test] cvs-1.11.5-1


On Sat, 26 Apr 2003, Charles Wilson wrote:

> Max Bowsher wrote:
>
> > Only tested binary/binary, I'm afraid.
> >
> > I've never liked the idea of using 2 characters where 1 will do. I even use
> > Unix line endings in non-Cygwin text files.
> >
> > One possible idea: Link it with binmode.o until someone contributes a patch
> > to apply correct binary/text/default opens in the source.
>
> Well, the problem is that's not how cvs is supposed to work.  As I
> understand it, files in the repository should ALWAYS be stored with unix
> line-endings (the term "binary" is slightly misleading in this context,
> as -kb "store in binary form" means to cvs "don't replace $foo$ tokens
> like $Id$ and $Revision$").
>
> And files in the local working directory should follow "the system
> convention" -- which I take to mean "use the mount mode" -- but only
> when the files contain text.  Fortunately, cvs assumes that all files
> contain text unless explicitly informed that they are binary data, via
> the -kb flag.  Thus,
>
>              repository          working dir
>               access               access
> ---------------------------------------------
> read:        unix         use mount mode unless -kb
> write:       unix         use mount mode unless -kb
>
> (fortunately, the "should I interpret/replace $foo$" stuff is handled in
> a separate codepath from the "should I use O_BINARY to fopen this file")
>
> Now IF existing repositories do NOT follow this convention (e.g.
> somebody has \r\n in text files in their repository) then upgrading to a
> cvs that DOES follow the convention will lead to all manner of FAQs
> ("cvs diff says every line has changed! cvs sucks!)
>
> Anyway, there's lots of places to screw up, so testing is a must -- and
> I haven't even attempted to suss out the code to see if it is behaving
> -- on cygwin -- as advertised in the table above.
> --Chuck

Chuck,

Note that the repository files themselves (i.e., "*,v") should have LF
line endings.  The data stored in those files might well have CRLF in
it...  Sorry if I'm restating the obvious.
	Igor
-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_		pechtcha at cs dot nyu dot edu
ZZZzz /,`.-'`'    -.  ;-;;,_		igor at watson dot ibm dot com
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

Knowledge is an unending adventure at the edge of uncertainty.
  -- Leto II


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]