Re: poll() bugs and patch

[Corinna Vinschen <cygwin at cygwin dot com>]

On Wed, Mar 13, 2002 at 10:20:30PM +0100, Boris Schaeling wrote:
> > Ok with me.  However, I'll not take that patch w/o a ChangeLog entry.
> > Please create one, Boris.
> 
> Here they are:
> - change.log
> - poll.patch
> - newpoll.cc (new implementation)
> - polltest.c (testcase)

Thanks for the patch.  I've applied it with some changes.  Sorry for
being picky but your indenting wasn't GNU coding style conformant.
It's not

  if ()
  {
    foo;
  }

but

  if ()
    {
      foo;
    }

I've fixed that for now.  Your ChangeLog isn't correct either but
I've fixed that too:

Not

        * poll.cc: variable open_fds removed, rearranged
	and added code to fix settings of revents

but

        * poll.cc: Remove variable open_fds, rearrange and add code
	to fix settings of revents.

Present tense, full stop.

Check out the next developers snapshot or update from CVS to see
your patch incorporated.

Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                                mailto:cygwin@cygwin.com
Red Hat, Inc.

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Bug reporting:         http://cygwin.com/bugs.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/