[PATCH] Cygwin: pty: Fix failure to clear switch_to_nat_pipe flag.

Takashi Yano takashi.yano@nifty.ne.jp
Mon Aug 21 08:53:25 GMT 2023


Hi Corinna,

On Mon, 21 Aug 2023 10:20:30 +0200
Corinna Vinschen wrote:
> Hi Takashi,
> 
> On Aug 19 15:07, Takashi Yano wrote:
> > After the commit fbfea31dd9b9, switch_to_nat_pipe is not cleared
> > properly when non-cygwin app is terminated in the case where the
> > pseudo console is disabled. This is because get_winpid_to_hand_over()
> > sometimes returns PID of cygwin process even though it should return
> > only PID of non-cygwin process. This patch fixes the issue by adding
> > a new argument which requests only PID of non-cygwin process to
> > get_console_process_id().
> 
> How critical is that? Do we need a 3.4.9 asap, or can we wait and
> collect a few more bugfixes first?

This problem is affected only when pseudo console is not
activated. So, most of Win10 users do not have this issue.
However, Win7/8 users may notice some small gritch after
non-cygwin app is executed.

BTW, are you noticed that dumper.exe is missing in 3.4.8?
When you release new cygwin to fix that, I would be happy
if above patch will applied as well.

Thanks.

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>


More information about the Cygwin-patches mailing list