This is the mail archive of the cygwin-patches mailing list for the Cygwin project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 7/23/2018 12:06 PM, Ken Brown wrote:
On 7/23/2018 11:37 AM, Corinna Vinschen wrote:On Jul 23 11:15, Ken Brown wrote:[Redirecting to cygwin-patches.] On 7/23/2018 11:06 AM, Corinna Vinschen wrote:On Jul 23 10:43, Ken Brown wrote:This is obviously very minor, but I bumped into it because of a failingemacs test.Cygwin's getfacl prints only one colon after "mask" and "other", but Linux's prints two. I'm sure this was done for a reason, but I'm wondering if itwould be better to follow Linux.The original version was designed after Solaris documentation, but the layout is supposed to look like Linux for a while, so ther missing colon is a bug.I'll be glad to submit a patch.Glad to review it :)Attached.Pushed. I just wonder if we shouldn't simplify getfacl to use acl_to_text instead.Yes, that makes sense. I'll take a look.
Patch attached.I thought it might be possible to simplify setfacl in a similar way, but I didn't see a way to do it.
Ken
Attachment:
0001-getfacl-Simplify-by-using-acl_to_any_text.patch
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |