This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] cygwin: make sys/socket.h completely visible from netinet/in.h


On Jan 19 01:28, Yaakov Selkowitz wrote:
> On 2018-01-16 03:30, Corinna Vinschen wrote:
> > You don't explain the incentive behind removing sys/time.h. 
> 
> POSIX does not mention the inclusion of <sys/time.h> in <sys/socket.h>
> or <netinet/in.h>, nor is there anything in the latter two that would
> require the former.  I can make this clearer in the commit message.
> 
> > Sure this doesn't break anything?
> Without a mass scratch rebuild I can never be 100% sure. :-)  But so
> far, no issues, and the first part of this definitely helps.

ACK.  Please apply these as two separate patches so we can easily revert
the include *if* it results in problems.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

Attachment: signature.asc
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]