This is the mail archive of the
cygwin-patches
mailing list for the Cygwin project.
Re: [PATCH v2] Refactor to avoid nonnull checks on "this" pointer.
- From: Peter Foley <pefoley2 at pefoley dot com>
- To: cygwin-patches at cygwin dot com
- Date: Fri, 1 Apr 2016 11:12:14 -0400
- Subject: Re: [PATCH v2] Refactor to avoid nonnull checks on "this" pointer.
- Authentication-results: sourceware.org; auth=none
- References: <1459441102-19941-1-git-send-email-pefoley2 at pefoley dot com> <20160401121318 dot GA16660 at calimero dot vinschen dot de> <56FE73D7 dot 8030306 at cygwin dot com> <CAOFdcFN0+eH76u6A0Z=gsyE8iEtzQFUTjyheQYzRk5Hfst_s=Q at mail dot gmail dot com> <20160401151040 dot GG16660 at calimero dot vinschen dot de>
On Fri, Apr 1, 2016 at 11:10 AM, Corinna Vinschen
<corinna-cygwin@cygwin.com> wrote:
> As I mentioned in my first reply, I'd prefer if the callers check the
> pointer explicitly. Changing the methods to static methods seems ...
> wrong. Ugly, if you don't mind me saying so.
Fair enough, I'll respin this at some point.