From 225f852594d9ff6a1231063ece3d529b9cc1bf7f Mon Sep 17 00:00:00 2001 From: John Hood Date: Sat, 30 Jan 2016 17:33:36 -0500 Subject: [PATCH 2/5] Move get_nonascii_key into fhandler_console. * fhandler.h (fhandler_console): Move get_nonascii_key() from select.c into this class. * select.cc (peek_console): Move get_nonascii_key() into fhandler_console class. --- winsup/cygwin/fhandler.h | 1 + winsup/cygwin/fhandler_console.cc | 4 +--- winsup/cygwin/select.cc | 3 +-- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/winsup/cygwin/fhandler.h b/winsup/cygwin/fhandler.h index 1c1862b..2dbe377 100644 --- a/winsup/cygwin/fhandler.h +++ b/winsup/cygwin/fhandler.h @@ -1469,6 +1469,7 @@ private: bool set_unit (); static bool need_invisible (); static void free_console (); + static const char *get_nonascii_key (INPUT_RECORD& input_rec, char *); fhandler_console (void *) {} diff --git a/winsup/cygwin/fhandler_console.cc b/winsup/cygwin/fhandler_console.cc index ef2d1c5..f683e90 100644 --- a/winsup/cygwin/fhandler_console.cc +++ b/winsup/cygwin/fhandler_console.cc @@ -46,8 +46,6 @@ details. */ #define srTop (con.b.srWindow.Top + con.scroll_region.Top) #define srBottom ((con.scroll_region.Bottom < 0) ? con.b.srWindow.Bottom : con.b.srWindow.Top + con.scroll_region.Bottom) -const char *get_nonascii_key (INPUT_RECORD&, char *); - const unsigned fhandler_console::MAX_WRITE_CHARS = 16384; fhandler_console::console_state NO_COPY *fhandler_console::shared_console_info; @@ -2391,7 +2389,7 @@ static const struct { }; const char * -get_nonascii_key (INPUT_RECORD& input_rec, char *tmp) +fhandler_console::get_nonascii_key (INPUT_RECORD& input_rec, char *tmp) { #define NORMAL 0 #define SHIFT 1 diff --git a/winsup/cygwin/select.cc b/winsup/cygwin/select.cc index 8f759a4..10205a0 100644 --- a/winsup/cygwin/select.cc +++ b/winsup/cygwin/select.cc @@ -883,7 +883,6 @@ fhandler_fifo::select_except (select_stuff *ss) static int peek_console (select_record *me, bool) { - extern const char * get_nonascii_key (INPUT_RECORD& input_rec, char *); fhandler_console *fh = (fhandler_console *) me->fh; if (!me->read_selected) @@ -925,7 +924,7 @@ peek_console (select_record *me, bool) { if (irec.Event.KeyEvent.bKeyDown && (irec.Event.KeyEvent.uChar.AsciiChar - || get_nonascii_key (irec, tmpbuf))) + || fhandler_console::get_nonascii_key (irec, tmpbuf))) return me->read_ready = true; } else -- 2.7.2