This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Re: Cygwin select() issues and improvements


On 3/14/2016 6:12 AM, Corinna Vinschen wrote:
Hi John,

On Mar 13 17:37, john hood wrote:
On 3/4/16 3:58 AM, Corinna Vinschen wrote:
John,


Ping?  I'd be interested to get your patches into Cygwin.  select
really needs some kicking :)
Sorry to be so slow responding.  Here's a rebased, squashed,
changelog-ified patch,
Thank you.  Uhm... I just don't understand why you squashed them into a
single big patch.  Multiple independent smaller patches are better to
handle, especially when looking for potential bugs later.

Would you mind terribly to split them again?
i just looked at this, but I'm going to leave the patch as a single patch. The patches in the original series are not completely independent of each other, it has a bug or two in the middle, and also some reversed edits. The endpoint is known tested and working, but some of the intermediate commits aren't that well tested. It *is* too big as a single commit-- but I think that's better than the original patch series from my development work, which I never intended to submit as-is anyway.

Regards,

  --jh


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]