Re: [PATCH] ccwrap: fix build with non-english locale set

[Eric Blake <eblake at redhat dot com>]

On 02/29/2016 06:19 AM, patrick bendorf wrote:
> after some discussion on irc and the list i'm resubmitting a simpler
> version of the patch.
> setting the locale on cygwin to 'C.UTF-8' is not needed, so i'm always
> setting it to 'C' which is sufficient for the build process and the most
> simple fix.
> 
> /winsup/
> * ccwrap: change locale to 'C' as ccwrap searches for literal strings
> "search starts here" and "End of search list" which may be localized.
> ---
>  winsup/ccwrap | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/winsup/ccwrap b/winsup/ccwrap
> index 7580e7a..0c6a170 100755
> --- a/winsup/ccwrap
> +++ b/winsup/ccwrap
> @@ -12,6 +12,7 @@ if ($ARGV[0] ne '++') {
>      $cxx = 1;
>  }
>  die "$0: $ccorcxx environment variable does not exist\n" unless exists
> $ENV{$ccorcxx};
> +$ENV{'LANG'} = 'C';

This won't work if I have LC_ALL set in my environment.  If you want to
force the locale, you want to set LC_ALL (highest priority), not LANG
(lowest priority).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature