This is the mail archive of the
cygwin-patches
mailing list for the Cygwin project.
Re: Fix sem_getvalue
- From: Christopher Faylor <cgf-use-the-mailinglist-please at cygwin dot com>
- To: cygwin-patches at cygwin dot com
- Date: Wed, 25 Sep 2013 10:46:43 -0400
- Subject: Re: Fix sem_getvalue
- Authentication-results: sourceware.org; auth=none
- References: <52389689 dot 1030801 at emsys dot de> <5242BDCD dot 6090003 at emsys dot de>
- Reply-to: cygwin-patches at cygwin dot com
On Wed, Sep 25, 2013 at 12:41:17PM +0200, Paul Kunysch wrote:
>> That looks like a reasonable fix. Did you trace through all of the
>> callers of semaphore::_getvalue to make sure that some of them aren't
>> relying on the old behavior?
>
>I did not look for other callers.
>
>I just wrote a very simple test for sem_getvalue() and copied different
>cygwin1.dll versions to my test-application.
I was being too vague here. You made what looks like a reasonable
change but it is to a low-level function which is called by more than
one place. I was hoping that, since you wanted to see this fixed, you
might also be willing to make sure that your change doesn't break
anything else. But, I didn't say that so, my bad.
I've checked in a modified version of your patch along with a ChangeLog.
Thanks.
cgf