This is the mail archive of the cygwin-patches mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 64bit] Fix speclib for x86_64

On Mon, Feb 18, 2013 at 04:19:17AM -0600, Yaakov wrote:
>On Sun, 17 Feb 2013 11:51:59 -0500, Christopher Faylor wrote:
>> >+my $uscore = ($target =~ /^x86_64\-/ ? undef : '_');
>> 
>> There is no reason to quote the dash here.  But, I would actually prefer
>> a substr check since that is a little faster.
>> 
>> my $uscore = (substr($target, 0, 7) eq 'x86_64-') ? ...
>
>I was just following the syntax already in mkimport:
>
>> my $is64bit = ($target =~ /^x86_64\-/ ? 1 : 0);

I haven't reviewed very many 64-bit changes to code that I wrote, like
mkimport or speclib.  However, my comment applies equally to mkkmport if
it is using a similar mechanism.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]