This is the mail archive of the
cygwin-patches
mailing list for the Cygwin project.
Re: missing va_end calls
- From: Christopher Faylor <cgf-use-the-mailinglist-please at cygwin dot com>
- To: cygwin-patches at cygwin dot com
- Date: Tue, 13 Oct 2009 09:43:10 -0400
- Subject: Re: missing va_end calls
- References: <4AD477DC.9040004@byu.net>
- Reply-to: cygwin-patches at cygwin dot com
On Tue, Oct 13, 2009 at 06:51:40AM -0600, Eric Blake wrote:
>-----BEGIN PGP SIGNED MESSAGE-----
>Hash: SHA1
>
>As promised:
>
>2009-10-13 Eric Blake <ebb9@byu.net>
>
> * external.cc (cygwin_internal): Use va_end.
> * fork.cc (child_copy): Likewise.
> * libc/bsdlib.cc (warn, warnx, err, errx): Likewise.
> * pinfo.cc (commune_request): Likewise.
> * strace.cc (strace::prntf, strace_printf): Likewise.
For consistency with a lot of other cygwin code please use "res" rather
than "result" in external.cc.
Other than that please check in.
Thanks.
cgf