This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [1.7] rename/renameat error


On Sep 29 20:10, Eric Blake wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> According to Corinna Vinschen on 9/29/2009 1:35 PM:
> > On Sep 29 13:18, Eric Blake wrote:
> >> I missed one corner case in my testing; how about this followup?
> >>
> >> 2009-09-29  Eric Blake  <ebb9@byu.net>
> >>
> >> 	* syscalls.cc (rename): Fix regression on rename("dir","d/").
> > 
> > Looks ok to me.  Isn't that partly covered by the next if, though?
> > YA piece of code lacking comments it seems.
> 
> I added a few comments before committing.  The difference between the two
> lines is that only the first one rejects rename("file","file2/"), and only
> the second rejects rename("dir","file"); both lines are needed.

Uh, right.  Thanks for adding the comments!


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]