This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix order of dtors problem.


Corinna Vinschen wrote:
> On Jul 30 09:51, Christopher Faylor wrote:
>> On Thu, Jul 30, 2009 at 02:47:06PM +0100, Dave Korn wrote:
>>>  This is the patch I'm currently testing (so far, uneventfully).  I thought I'd
>>> send it here for posterity just in case I get squashed by a falling hippo or
>>> anything over the weekend.
>>>
>>> winsup/cygwin/ChangeLog:
>>>
>>> 	* globals.cc (enum exit_states::ES_GLOBAL_DTORS): Delete.
>>> 	* dcrt0.cc (__main): Schedule dll_global_dtors to run
>>> 	atexit before global dtors.
>>> 	(do_exit): Delete test for ES_GLOBAL_DTORS and call to
>>> 	dll_global_dtors.
>> FWIW, this looks fine.
> 
> I could simply check it in and create -53 from there...
> 

  That sounds like a fairly reasonable way of getting it some wider beta testing
than I can do on my own.  I think it's likely to all be OK, so how about we
change the plan to checking it in now and *reverting* it if any problems show up
by the other side of the weekend?

    cheers,
      DaveK


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]