This is the mail archive of the
cygwin-patches
mailing list for the Cygwin project.
Re: [PATCH] Separate pthread fixes #1
- From: Christopher Faylor <cgf-use-the-mailinglist-please at cygwin dot com>
- To: cygwin-patches at cygwin dot com
- Date: Wed, 3 Jun 2009 21:30:24 -0400
- Subject: Re: [PATCH] Separate pthread fixes #1
- References: <4A27031C.7030800@gmail.com>
- Reply-to: cygwin-patches at cygwin dot com
On Thu, Jun 04, 2009 at 12:11:24AM +0100, Dave Korn wrote:
>
> The attached patch separates out the uncontroversial change to the
>__cygwin_lock* functions.
>
>winsup/cygwin/ChangeLog
>
> * thread.cc (__cygwin_lock_lock): Delete racy optimisation.
> (__cygwin_lock_unlock): Likewise.
>
> OK?
Yes. Thanks.
FWIW, I have made this same change many times over the years but I was
always afraid of the performance hit so I've ended up reverting it.
Since you've demonstrated a real problem, performance concerns obviously
don't matter.
cgf