This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: memmem issues


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Corinna Vinschen on 12/20/2007 3:11 AM:
|> +  /* FIXME - this algorithm is worst-case O(l_len*s_len)...
|
| or what about Boyer-Moore instead:
|
|   http://de.wikipedia.org/wiki/Boyer-Moore-Algorithmus (in German)
|
| Using one of them is certainly not a licensing violation since all code
| examples are more or less the published examples from well-known
| textbooks (Knuth, Sedgewick, et al.).  Given that, I don't think you're
| actually "tainted".  An actual implementation would be much better than
| a forlorn comment in an unimpressive file in some subdirectory.

I took you up on that, and submitted an even better implementation to the
newlib list, shared among memmem, strstr, and strcasestr
(Knuth-Morris-Pratt and Boyer-Moore both require memory allocation, but
not Two-Way).  If Jeff gives the go-ahead for newlib, then we'll need to
delete cygwin's copy of memmem.cc.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             ebb9@byu.net
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHhu6l84KuGfSFAYARAg4WAJ9+8FkRcJlFaFYG/ouvK+4x/VQIlQCeJ03y
e9u22aTS92xNaLELTW+otK4=
=9rXA
-----END PGP SIGNATURE-----


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]