This is the mail archive of the
cygwin-patches
mailing list for the Cygwin project.
Re: [patch] Handling non-winsock flags in fhandler_socket.cc
- From: Corinna Vinschen <corinna-cygwin at cygwin dot com>
- To: cygwin-patches at cygwin dot com
- Date: Thu, 8 Dec 2005 11:14:04 +0100
- Subject: Re: [patch] Handling non-winsock flags in fhandler_socket.cc
- References: <80fd4e750512071319r4ae0bc2fj9c0fb5b9e29c398f@mail.gmail.com>
- Reply-to: cygwin-patches at cygwin dot com
On Dec 7 23:19, Pekka Pessi wrote:
> Hello,
>
> I found a problem with sendmsg() failng when MSG_NOSIGNAL is used. It
> looks like MSG_WINMASK is used in sendto() but not in sendmsg().
Thanks for the patch. Unfortunately it's missing a ChangeLog entry and
it didn't work OOTB since it was missing curly braces, but I took the
freedom to fix it up. The change to fhandler_socket::recvfrom was not
necessary since flags is masked at the start of the function. However,
maybe it comes handy to keep the original flags value at one point, so
I removed this masking at the function start.
Please note that I can take this patch only because it's relatively
small. If you would like to send bigger patches or extensions to the
Cygwin functionality at one point, you'll have to sign a copyright
assignment form and send it to Red Hat. Please read
http://cygwin.com/contrib.html for more details about contributing.
Other than that, patch applied with changes.
Thanks again,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Project Co-Leader cygwin AT cygwin DOT com
Red Hat, Inc.