This is the mail archive of the cygwin-patches mailing list for the Cygwin project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Mon, Aug 01, 2005 at 06:56:39PM +0200, Corinna Vinschen wrote: > On Aug 1 04:15, Yitzchak Scott-Thoennes wrote: > > I don't have a serial device to test this with, but it's just selected > > parts of the TIOCMSET handling slightly adapted. > > I'm not serial I/O savvy, but the change looks pretty much ok. I'm just > not exactly glad that the functionality itself is duplicated. Would you > mind a rewrite so that the functionality is not copied, for instance by > creating a private method which does it, or by recursively calling > fhandler_serial::ioctl() with tweaked arguments (TIOCMSET)? No problem. How does this look? 2005-08-01 Yitzchak Scott-Thoennes <sthoenna@efn.org> * include/sys/termios.h: Define TIOCMBIS and TIOCMBIC. * fhandler.h (class fhandler_serial): Declare switch_modem_lines. * fhandler_serial.cc (fhandler_serial::switch_modem_lines): New static function to set or clear DTR and/or RTS. (fhandler_serial::ioctl): Use switch_modem_lines for TIOCMSET and new TIOCMBIS and TIOCMBIC.
Attachment:
tiocmbi.patch
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |