This is the mail archive of the
cygwin-patches
mailing list for the Cygwin project.
Re: [PATCH] TIOCMBI[SC]
- From: Corinna Vinschen <corinna-cygwin at cygwin dot com>
- To: cygwin-patches at cygwin dot com
- Date: Mon, 1 Aug 2005 18:56:39 +0200
- Subject: Re: [PATCH] TIOCMBI[SC]
- References: <20050801111552.GA2844@efn.org>
- Reply-to: cygwin-patches at cygwin dot com
On Aug 1 04:15, Yitzchak Scott-Thoennes wrote:
> I don't have a serial device to test this with, but it's just selected
> parts of the TIOCMSET handling slightly adapted.
I'm not serial I/O savvy, but the change looks pretty much ok. I'm just
not exactly glad that the functionality itself is duplicated. Would you
mind a rewrite so that the functionality is not copied, for instance by
creating a private method which does it, or by recursively calling
fhandler_serial::ioctl() with tweaked arguments (TIOCMSET)?
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Project Co-Leader mailto:cygwin@cygwin.com
Red Hat, Inc.