This is the mail archive of the cygwin-patches mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: cygcheck .exe magic


On Tue, Jul 19, 2005 at 08:35:27PM +0000, Eric Blake wrote:
>Christopher Faylor <cgf-no-personal-reply-please <at> cygwin.com> writes:
>>Are you sure this is right?  cygcheck.exe isn't a cygwin program so I'd
>>wonder about the use of the inodes returned from windows stat() call.
>
>You have a point; revised patch attached.  The original worked for me
>in testing, but only because I was short-circuiting when the first stat
>failed, and appending the .exe happened to be the right thing to do.
>Since this is not a cygwin app, there is no .exe magic in stat() to
>counteract, and all we really need to do is see if appending the suffix
>makes stat succeed.

We don't really need stat() to do this checking since we're inspecting
anything in the stat structure.  So, I've rewritten this patch to just
use access() as other parts of cygcheck do.  It's been checked in.

Thanks,
cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]