This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
From: Corinna Vinschen Subject: Re: [Patch] To handle Win32 pipe names Date: Wed, 19 May 2004 10:52:37 +0200
Stephen,
On May 17 12:57, Stephen Cleary wrote:
> Attached is a patch against the current CVS sources, with a ChangeLog. This
> patch allows Win32 pipe names to be opened as files.
that's still not quite what I had in mind. I'd like to see as less special windows path handling in Cygwin as possible. A //foo/pipe/whatever path is just like any other UNC path and could be handled as such, no extra code should be necessary. //./pipe/whatever should also go through without any extra code so the whole idea would be to do exactly nothing, except the existing code has a bug, of course. I really don't care for stat. If Windows named pipes are recognized as files, so be it.
I've just quickly stepped through the existing code and it looks like \\.\foo paths can be opened normally on NT. Just stat seems to have a problem, since stat_worker checks for fh->exists() at one point and GetFileAttributes returned INVALID_FILE_ATTRIBUTES on devices. So that explains your patch to symlink_info::check. But it's not exactly right to circumvent this only for pipes. Any \\.\foo path should get the same handling. Wouldn't it be more straightforward to use is_unc_share or a slightly modified version of is_unc_share?
Your thoughts? -Steve
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |