This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch]: chdir


On Tue, May 04, 2004 at 08:20:03PM -0400, Christopher Faylor wrote:
>On Tue, May 04, 2004 at 08:03:59PM -0400, Pierre A. Humblet wrote:
>>Here is a simple patch that simplifies chdir processing
>>and avoids calling normalized_posix_path multiple times.
>>
>>If it doesn't break anything it will simplify removing
>>trailing dots and spaces, as discussed earlier today.
>
>"If it doesn't break anything" does not leave me filled with confidence
>that this patch is appropriate for application as we are anticipating
>releasing 1.5.10.

Another thing occurs to me -- maybe it would simplify things just to
store a patch_conv structure on the cygheap rather than use a separate
cwdstuff structure.  It would take up more space on the cygheap but I
think it would probably be cleaner in general.

cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]