This is the mail archive of the
cygwin-patches@cygwin.com
mailing list for the Cygwin project.
Re: [Patch]: path.cc
On Apr 9 23:19, Pierre A. Humblet wrote:
> Looking to the future, now that fs_info::update isn't really doing an
> update (a better name would be fs_info::get), it turns out that the
> char name_storage[CYG_MAX_PATH];
> char root_dir_storage[CYG_MAX_PATH];
> fields in fs_info can be removed (that requires a few other minor changes).
> Doing that would cut down the size of a fhandler from about 920 bytes
> to 400, which looks like a good thing.
Yes, you're right. I'm going to work on this.
> But coincidentally Corinna has also worked on related stuff today.
> With her edit an even more efficient option would be to change
> fs_info fs;
> to
> fs_info * fs_ptr;
> in path_conv. Corinna, are you heading that way?
Not yet, no. The global fs_info storage doesn't store information about
removable storage so the path_conv needs a local member to keep that
information.
> I am somewhat concerned that the update of fsinfo isn't thread safe.
> I don't know how the overhead of making it thread safe compares with
> the overhead of the old method (not caching the fs_info).
I'll change that soon.
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Developer mailto:cygwin@cygwin.com
Red Hat, Inc.