This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Fri, 15 Aug 2003, David Rothenberger wrote: > Corinna Vinschen wrote: > > Thanks for the patch, it's really cool, > > I agree, very cool, Igor. > > Any chance the return in package_find() could be changed to > continue? I went to try it out for /bin/ssh and found it didn't > work because diffutils is missing the package list. I didn't think > to even try verbose until I read the code. > > Here's the ridiculously small patch if you agree. > > Dave > ============================== > 2003-08-15 David Rothenberger <daveroth@acm.org> > > * dump_setup.cc (package_find): Don't stop searching on missing > file list. Dave, Thanks for catching this -- this was a genuine bug. Thanks also for the patch, but I have another one in the pipeline that'll conflict with yours (<http://cygwin.com/ml/cygwin-patches/2003-q3/msg00105.html>). How about I just resubmit that patch with your changes included? Attached is a new patch, with an updated ChangeLog entry (well, two entries). Igor ============================================================================== ChangeLog: 2003-08-15 David Rothenberger <daveroth@acm.org> * dump_setup.cc (package_find): Don't stop searching on missing file list. (package_list): Ditto. 2003-08-15 Igor Pechtchanski <pechtcha@cs.nyu.edu> * dump_setup.cc: (package_list): Make output terse unless verbose requested. Fix formatting. (package_find): Ditto. -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_ pechtcha@cs.nyu.edu ZZZzz /,`.-'`' -. ;-;;,_ igor@watson.ibm.com |,4- ) )-,_. ,\ ( `'-' Igor Pechtchanski, Ph.D. '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! "I have since come to realize that being between your mentor and his route to the bathroom is a major career booster." -- Patrick Naughton
Attachment:
cygcheck-list-verbose.patch
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |