This is the mail archive of the
cygwin-patches@cygwin.com
mailing list for the Cygwin project.
Re: [PATCH] updated pthread list patch
On Thu, Mar 20, 2003 at 09:22:42AM +1100, Robert Collins wrote:
>I'm happy with changing the method naming format, but is it GNU
>standard? Thats a requirement for the cygwin project.
>
>http://www.gnu.org/prep/standards_26.html#SEC26 says that
>"For example, you should use names like ignore_space_change_flag; don't
>use names like iCantReadThis."
>
>Now, I happen to disagree with the GNU conventions here, particularly as
>they don't have a C++ section (and C doesn't have the same degree of
>name space conflicts that C++ does) :}. But, the pthread code should
>stay within the GNU guidelines.
>
>So, I'm sorry to have you jumping through hoops, but can you please
>change your patch so that all new methods use the GNU convention here.
Yes, again, I'd just like to be consistent in cygwin. While there are
a few isFooBar type of things in the code, for the most part we don't
do things that way here. I don't have a strong feeling either way but
I find it jarring to see things done one way in one section of the code
and another in other sections. So, I change this kind of thing when I
stumble across it.
So, I agree with Robert. Lets try to stick with the current way of
doing things since the majority of the code does things that way.
Also see my 1 == foo commentary earlier.
cgf