This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] line_edit return value


On Sat, Nov 30, 2002 at 05:02:21PM -0600, Steve O wrote:
>ChangeLog entry
>2002-11-30 Steve Osborn <bub@io.com>
>	* fhandler.h (fhandler_termios::line_edit): Changed return
>	  from an int to an enum to allow the function to return an
>	  error.
>	* fhandler_console.cc (fhandler_console::read): Updated the
>	  line_edit call to use the new enum.
>	* fhandler_termios.cc (fhandler_termios::line_edit): Changed 
>	  return from an int to an enum to allow the function to return an
>          error.  Put put_readahead call before doecho for future patch. 
>	* fhandler_tty.cc (fhandler_pty_master::write): Changed to 
>	  call line_edit one character at a time, and stop if an error
>	  occurs.

Something was bugging me about this patch Basically it seems like maybe
we ought to be storing the line_edit state in the fhandler_tty structure
or something but maybe that's too big a change.  I couldn't convince
myself that the code would be any clearer as a result of such a change
either.  I could convince myself that the tty stuff needs to be rewritten
from scratch, though.  :-)

Anyway, I've checked this in after reformatting the ChangeLog.

Thanks,
cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]