This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
At 08:57 PM 11/14/2002 +0100, Corinna Vinschen wrote: >On Thu, Nov 14, 2002 at 08:21:05PM +0100, Corinna Vinschen wrote: >> is_grp_member() calls getgroups32() only for the current user and >> scans passwd and group otherwise, trying to be more efficient. > >Btw., it "feels" faster now to call ls -l... Great! Here are my patches. I think they are as we agreed on. Pierre 2002-11-15 Pierre Humblet <pierre.humblet@ieee.org> * security.cc (get_attribute_from_acl): Always test "anti", just in case an access_denied ACE follows an access_allowed. Handle the case owner_sid == group_sid. Remove unnecessary tests for non-NULL PSIDs. (alloc_sd): Use existing owner and group sids if {ug}id == -1. Handle case where owner_sid == group_sid. Do not call is_grp_member. Try to preserve canonical ACE order. Add unrelated access_denied ACEs around the owner_allow. Remove unnecessary tests for non-NULL PSIDs. Reorganize debug_printf's. (get_initgroups_sidlist): Put well_known_system_sid on left side of ==. (add_access_denied_ace): Only call GetAce if inherit != 0. (add_access_allowed_ace): Ditto. Use appropriate sizeof. * syscalls.cc (chown_worker): Pass {ug}id equal to -1 to alloc_sd, which removes the need to obtain old_{ug}id. (chmod): Remove call to get_file_attribute (), simply pass {ug}id equal to -1 to alloc_sd.
Attachment:
sec.diff
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |