This is the mail archive of the
cygwin-patches@cygwin.com
mailing list for the Cygwin project.
Re: serial patch - second attempt
What can I say ? I do not know reason You changed wincap.is_winnt() on
wincap.must_init_serial_line(). In my opinion conditionals utilizing
is_wint() are better but if You do want to change it I suggest something
like wincap.support_modem_output_lines_reading
which is accurate to function it serves to.
Jacek
Corinna Vinschen wrote:
>
> On Wed, Jul 24, 2002 at 10:10:52AM +0200, Jacek Trzcinski wrote:
> > What means !!!!! :-)
>
> It means:
>
> If you think that the name of the new capability is inappropriate,
> please suggest another name.
>
> Corinna
>
> >
> > Jacek
> >
> > Corinna Vinschen wrote:
> > >
> > > On Wed, Jul 24, 2002 at 10:01:39AM +0200, Jacek Trzcinski wrote:
> > > > Hi !
> > > > I think that there is a problem with this name. In case of serial
> > > > initialization (in method fhandler_serial::open()) it could be utilized
> > > > because its goal is connected with name - it initializes RTS and DTR
> > > > serial lines. Problem is in method fhandler_serial::ioctl().
> > > > Conditional paths utilized by me are concerned with the fact that under
> > > > NT , native serial device driver supports reading of RTS and DTR lines
> > > > by DeviceIoControl() function. Under 9x native serial driver does not
> > > > support it so utilized variables dsr and rts, setting in different
> > > > places of fhandler_serial.cc. Thus in my opinion, saying
> > > > "must_init_serial_line" in ioctl() method is not accurate because there
> > > > is none initialization there.
> > >
> > >
> > > !!!!!
> > >
> > > Corinna
> > >
> > > --
> > > Corinna Vinschen Please, send mails regarding Cygwin to
> > > Cygwin Developer mailto:cygwin@cygwin.com
> > > Red Hat, Inc.
>
> --
> Corinna Vinschen Please, send mails regarding Cygwin to
> Cygwin Developer mailto:cygwin@cygwin.com
> Red Hat, Inc.