This is the mail archive of the
cygwin-patches@cygwin.com
mailing list for the Cygwin project.
Re: [PATCH] w32api (some general, some Watcom related)
- From: Danny Smith <danny_r_smith_2001 at yahoo dot co dot nz>
- To: Bart Oldeman <bart dot oldeman at btinternet dot com>, cygwin-patches <cygwin-patches at cygwin dot com>
- Date: Sun, 21 Jul 2002 10:28:57 +1000 (EST)
- Subject: Re: [PATCH] w32api (some general, some Watcom related)
> 2002-07-17 Bart Oldeman <bart.oldeman@btinternet.com>
>
> * include/shlobj.h (FCIDM_MENU_FAVORITES): remove bogus character.
> * include/winsock2.h (struct sockaddr): use __int64 instead of
> long long
> * include/kernel32.c (GetCurrentFiber): Watcom does not need
> external *Fiber library functions.
> * include/kernel32.c (GetFiberData): likewise
>
I have checked in above changes, but not this:
> * include/windef.h: (PACKED) Watcom compatible #define for
> structure packing
> * include/wincon.h (KEY_EVENT_RECORD): use the above
My tests indicate that the packed attribute is not necessary for
KEY_EVENT_RECORD (the default alignment is same as PACKED) and could be
removed. Bart indicates that it is not necesssary for Watcom either. Since the
PACKED define is used nowhere else in w32api, I would be inclined to remove it
completely from windef.h, but that may break some user code that depends on
it..., so I'll leave it alone.
Danny
http://www.sold.com.au - SOLD.com.au
- Find yourself a bargain!