This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Reorganizing internal_getlogin() patch is in


On Sun, Jun 16, 2002 at 01:15:06AM -0400, Christopher Faylor wrote:
>>In env_userprofile () I don't understand why the last two conditions
>>are useful in:
>>  if (strcasematch (name (), "SYSTEM") || !env_domain () || !env_logsrv ())
>>The domain should never be NULL, and the logserver only NULL for SYSTEM.
>
>The domain can be NULL if LookupAccountSid fails.  get_logon_server can
>fail, also.  Certainly it makes sense to fail gracefully, no?

Nevermind.  I realized what you meant 2 seconds after hitting 'y'.  I'll nuke
these tests.

cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]