This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Name aliasing in security.cc


On Thu, Jun 06, 2002 at 10:07:46AM -0400, Pierre A. Humblet wrote:
> Corinna Vinschen wrote:
> > 
> > On Wed, Jun 05, 2002 at 08:23:59PM -0400, Pierre A. Humblet wrote:
> > > I saw the changes in grp.cc and passwd.cc where you make default
> > > entries from the token. That's a good idea, very close to what I had
> > > in mind for the "except" clause" in suggestion c) above.
> 
> Corinna,
> 
> Something came to my mind last night: the sid that your new code in
> passwd.cc gets from the token should already be in user.sid (and 
> user.orig_sid). Why not get it from there instead?

You're right but it doesn't matter since I have to open the token
anyway since I need the primary group which isn't available at that
point.

> I also have a question: why does internal Cygwin code use 
> strcasematch() instead of !strcasecmp()? I (ignorantly) used
> strcasecmp() recently, it seems to work.

It's faster than strcasecmp.

Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                                mailto:cygwin@cygwin.com
Red Hat, Inc.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]