This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch for sub-second resolution in stat(2)


"Christopher Faylor" <cgf@redhat.com> wrote:
> The ChangeLog is closer, but still not complete.  You should provide a
> *complete* ChangeLog, including time/date name, email address.  The
> entries should also be capitalized ("Ditto."  not "ditto.").
>
> If you can also indent the code, as per a normal ChangeLog, that is good,
> too.
>
> The goal is for this process to be as painless for the person applying the
> patch as possible.  There are two reasons for this 1) It's nice to be nice
> and 2) A patch reviewer is apt to be more interested in a patch if it
looks
> clean and requires little or no editing.  This means that your patch gets
> applied faster and you get a reputation for submitting good patches (take
> a bow Joshua).

Sorry about that and thanks for the tips: I'll do it that way next time.

// Conrad




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]