This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] dtors run twice on dll detach (update)


On Fri, Apr 19, 2002 at 10:46:28PM +1000, Robert Collins wrote:
>
>
>> -----Original Message-----
>> From: Thomas Pfaff [mailto:tpfaff@gmx.net] 
>> Sent: Wednesday, April 17, 2002 5:08 PM
>
>> > Since i can not judge which function is obsolete (i guess
>> > dll_global_dtors
>> > is) i have attached a small patch that will make sure that 
>> the dtors run
>> > only once.
>
>I'm not sure that either function is obsolete - I'll let Chris/Corinna
>comment on that.. Your patch looked good, and corrected a test case I
>happened to have hanging around, so I've checked this in as an
>appropriate solution. Thanks for the patch.

If one of the functions is obsolete, it should be deleted.  That means
that the patch does *not* look good.  It needs to be reviewed.

That plus the fact that you don't have global checkin privileges for
cygwin == cgf reverts the patch.

cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]