This is the mail archive of the mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

small setup.exe fix


Pressing 'Add' in the `Choose a dowload site' dialogue without typing
an url causes a segfault over here.  Fix below.


2002-01-29  Jan Nieuwenhuizen  <>

	* (OnMessageCmd): Bugfix: don't try to add NULL url.

--- ../cinstall.orig/	Tue Jan 29 10:24:34 2002
+++ ./	Tue Jan 29 22:17:13 2002
@@ -415,6 +415,8 @@ bool SitePage::OnMessageCmd (int id, HWN
 	    // User pushed the Add button.
 	    other_url = eget (GetHWND (), IDC_EDIT_USER_URL, other_url);
+	    if (!other_url)
+	      break;
 	    site_list_type *
 	      newsite =

Program received signal SIGSEGV, Segmentation fault.
0x0041c1f1 in site_list_type::init (this=0xb38610, newurl=0x0) at
56 No such file or directory.
Current language:  auto; currently c++

(gdb) bt
#0  0x0041c1f1 in site_list_type::init (this=0xb38610, newurl=0x0)
#1  0x0041c3cb in site_list_type::site_list_type (this=0xb38610, newurl=0x0)
#2  0x0041d218 in SitePage::OnMessageCmd (this=0xa0fa88, id=1063, 
    hwndctl=0x8c0, code=0) at
#3  0x0041ac6a in PropertyPage::DialogProc (this=0xa0fa88, message=273, 
    wParam=1063, lParam=2240) at
#4  0x0041aa7b in PropertyPage::DialogProcReflector (hwnd=0x8fc, message=273, 
    wParam=1063, lParam=2240) at
#5  0xbff7363b in _libwsock32_a_iname ()
#6  0xbff942e7 in _libwsock32_a_iname ()
#7  0x00008388 in ?? ()
#8  0x00058f64 in ?? ()
Cannot access memory at address 0xc9b60f5d

Jan Nieuwenhuizen <> | GNU LilyPond - The music typesetter       |

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]