This is the mail archive of the
mailing list for the Cygwin project.
Re: [PATCH]Reduce messages in setup.log
----- Original Message -----
From: "Robert Collins" <email@example.com>
To: "Michael A Chase" <firstname.lastname@example.org>; <email@example.com>
Sent: Monday, January 28, 2002 21:38
Subject: Re: [PATCH]Reduce messages in setup.log
> ----- Original Message -----
> From: "Michael A Chase" <firstname.lastname@example.org>
> > If the intention of those messages is to highlight methods that should
> > been overridden but aren't, then setup.log is the right place.
> Essentially, yes thats why they are there: incomplete methods. When I
> review your patch I'll be looking at the function status.
There's no sense spending your time on the patch. I need to change it
drastically or withdraw it.
If I understand the intent:
1. If a method only returns a constant 0, the message should go to
setup.log.full to make it easier to tell where more work may be needed.
2. If a method does more than just return a constant 0, it should not call
log(), or if it does, the message is only needed in setup.log.
Performs actual work: compress_bz::peek(), compress_gz::peek(),
compress_gz::~compress_gz(), io_stream_cygfile::peek(), and
Returns NULL: archive::next_file_name(), compress::next_file_name(), and
Returns -1: compress_bz::seek() and compress_gz::seek().
** I normally forward private questions to the appropriate mail list. **
Ask Smarter: http://www.tuxedo.org/~esr/faqs/smart-questions.htm
Give a hobbit a fish and he eats fish for a day.
Give a hobbit a ring and he eats fish for an age.