This is the mail archive of the
cygwin-patches@cygwin.com
mailing list for the Cygwin project.
Re: [PATCH] cinstall - Initialize all global state variables
- To: cygwin-patches at cygwin dot com
- Subject: Re: [PATCH] cinstall - Initialize all global state variables
- From: Christopher Faylor <cgf at redhat dot com>
- Date: Tue, 6 Nov 2001 11:57:22 -0500
- References: <OE59HpQHyD1C0Ug8cpF00003953@hotmail.com> <1005045929.5221.0.camel@lifelesswks> <3BE7CA86.2EBAC42D@syntrex.com> <3BE7DFE6.E8062434@syntrex.com> <1005052267.2726.19.camel@lifelesswks> <3BE7F07A.1418CA29@syntrex.com>
- Reply-To: cygwin-patches at cygwin dot com
On Tue, Nov 06, 2001 at 03:15:22PM +0100, Pavel Tsekov wrote:
>Attached is a patch which initializes all global state variables used
>in cinstall with zero values. The patch is a result from a discussion
>in the cygwin maling list about a strange behaviour of setup.exe
>resulting in heavy memory usage and process crash/freeze. The
>following link gives additional information about this behaviour:
>http://sources.redhat.com/ml/cygwin/2001-11/msg00304.html
If you have to initialize globals to zero something is drastically wrong
somewhere.
I would suggest finding out why this patch is necessary. It sounds like
a shotgun approach to the problem to me.
cgf