This is the mail archive of the cygwin-patches@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: yet another "pedantic" patch


Hi!

Saturday, 15 September, 2001 Christopher Faylor cgf@redhat.com wrote:

CF> It looks ok except for this:

CF> +  if (check_null_empty_str (topath) == EFAULT)
CF> +    {
CF> +      set_errno (EFAULT);
CF> +      goto done;
CF> +    }
CF> +  if (check_null_empty_str_errno (frompath))
CF> +    goto done;

CF> There is no reason for this duplication is there?  Can't this just be
CF> check_null_empty_str_errno?

ah, right. i was thinking for some reason that check_null_empty_str_errno()
returns true/false.

Egor.            mailto:deo@logos-m.ru ICQ 5165414 FidoNet 2:5020/496.19

check-args-validity-3.diff

check-args-validity-3.ChangeLog


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]