This is the mail archive of the cygwin-developers mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: 64bit: C++ templates


Hi,

the issue is a more general on and related to harfbuzz' use of
-fvisibility-inlines-hidden for mingw-targets, but not for cygwin
targets.  Btw the issue should be latent present for 32-bit too.
Well, nevertheless my test have shown that this option indeed fixes
that described issue.

Question here is if we shouldn't make visibility for inlines always
hidden on pe-coff targets.  I will think about this a bit.  The
following patch would do that:

Regards,
Kai

Index: decl2.c
===================================================================
--- decl2.c     (Revision 198882)
+++ decl2.c     (Arbeitskopie)
@@ -2308,7 +2308,11 @@ determine_visibility_from_class (tree decl, tree c
 static bool
 determine_hidden_inline (tree decl)
 {
-  return (visibility_options.inlines_hidden
+  return ((visibility_options.inlines_hidden
+#ifdef TARGET_PECOFF
+          || TARGET_PECOFF
+#endif
+         )
          /* Don't do this for inline templates; specializations might not be
             inline, and we don't want them to inherit the hidden
             visibility.  We'll set it here for all inline instantiations.  */


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]