Re: ntea & chmod

[Corinna Vinschen <vinschen at redhat dot com>]

On Aug 28 23:38, Pierre A. Humblet wrote:
> For example in ::fchmod, the line
>       if (!set_file_attribute (pc.has_acls (), get_io_handle (), pc,
>                                ILLEGAL_UID, ILLEGAL_GID, mode)
>           && allow_ntsec)
>         res = 0;
> guarantees a -1 return when ntea is on and allow_ntsec is off.

No, that's not right.  It gurantees a 0 return if set_file_attribute
has returned success and ntsec is on.  The difference is that ntea
depends on the return code of SetFileAttributes.  The `else' branch
isn't quite correct, though.  It must be 

  else if (!allow_ntsec || !pc.has_acls ())

I fixed that.

> set_file_attribute (path_conv & pc ....   <=== new arg type
> {
>   int ret = 0;
> 
>   if (allow_ntsec && pc.has_acls ())
>     ret = set_nt_attribute (handle, file, uid, gid, attribute);
>   else if (allow_ntea && pc.fs_has_ea ())
>     {
>       SetFileAttributes (pc, (DWORD) pc & ~FILE_ATTRIBUTE_READONLY)
>       bool res = NTWriteEA (file, ".UNIXATTR", (char *) &attribute,
>                                      sizeof (attribute)))
>       ....
>      }
>  
> pc.fs_has_ea () should be set properly as well in path.cc.
> Currently it's set to make sense for symlink (that's obsolete),

Obsolete?  Hmm, you're right, PC_CHECK_EA is never set anywhere, AFAICS.
Do we still need that code?

> not for ntea.

Yeah, it's only set for local NTFS.  It could also be set for FAT.
But the above change wouldn't work in all circumstances, see mkdir()
for instance;

  if (!allow_ntsec && allow_ntea)
    set_file_attribute (false, NULL, real_dir.get_win32 (), ...);
                        ^^^^^
except you keep the use_ntsec argument. 

I'm wondering though if it still makes sense to keep the
get/set_file_attribute functions as they are.  Except for two cases,
the functions are either called for the ntsec or for the ntea case
exclusively.  Perhaps it would make things clearer again, if we use
get/set_nt_attribute (resp. get_nt_object_attribute) and another
function pair get/set_ea_attribute.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          mailto:cygwin@cygwin.com
Red Hat, Inc.