Re: biggest... check-in... ever...

[Corinna Vinschen <vinschen at redhat dot com>]

Hi,

On Tue, Sep 23, 2003 at 12:08:58AM -0400, Christopher Faylor wrote:
> Tomorrow, I will check in my massive rewrite of fhandler stuff to deal
> with devices in a different way.  It will eventually allow on-disk
> device files.  It sort of does now but managed mode clobbered this a
> little.

after a long pause I tried the branch again.

There's still the naming of the harddisk devices which is different
from what they are named before.  They should be named /dev/sd.., 
not /dev/hd..

Makefile.in is missing a rule to create devices.cc from devices.gperf.
I tried `gperf -t -D --language=C++ devices.gperf > devices.cc' and the same
without language option but both calls result in a bunch of error messages.
How do I call it correctly?

The last point is, I'm not sure a hash is appropriate here.  What's
the gain?  The fixed devices are always prepended by "/dev/", so this
part has no meaning in the hash at all.  The remainder of the name is
mostly 3 chars in length.  Wouldn't a binary array search be better
for this?  It would drop the need to use gperf, btw.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Developer                                mailto:cygwin@cygwin.com
Red Hat, Inc.