This is the mail archive of the cygwin-developers@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Should check_ntsec() be added to cygwin?


On Wed, Mar 26, 2003 at 08:32:37PM +0100, Corinna Vinschen wrote:
> On Wed, Mar 26, 2003 at 01:49:50PM -0500, Christopher Faylor wrote:
> > If you do work up a patch, however, if at all feasible, please use
> > the cygwin_internal call for providing this functionality.
> 
> I agree.

What is the criterion for using cygwin_internal() versus just exporting
a function from the DLL?  I was thinking of cygwin_check_ntsec() like
cygwin_logon_user().

Additionally, I'm concerned that cygwin_internal() requires including
windows.h which has caused me problems in the past.  For example when
porting proftpd, I had to do the following:

    #ifdef CYGWIN
    typedef void *HANDLE;
    typedef unsigned long DWORD;
    #define INVALID_HANDLE_VALUE (HANDLE)(-1)
    #define WINAPI __stdcall
    DWORD WINAPI GetVersion(void);
    extern HANDLE cygwin_logon_user (const struct passwd *, const char *);
    extern void cygwin_set_impersonation_token (const HANDLE);
    ...

to workaround this issue.

> What I'm not quite sure is if it should still test for ntea though.

I will start with your current functionality.  We can always tweak as we
go.

Thanks,
Jason

-- 
PGP/GPG Key: http://www.tishler.net/jason/pubkey.asc or key servers
Fingerprint: 7A73 1405 7F2B E669 C19D  8784 1AFD E4CC ECF4 8EF6


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]