small_print vs system_printf

Christopher Faylor cgf@redhat.com
Tue Jul 2 20:19:00 GMT 2002


On Wed, Jul 03, 2002 at 04:04:02AM +0100, Conrad Scott wrote:
>I've just noticed that in various places in the DLL, small_print is
>called directly.  Most of these look (to me) like they should be using
>system_printf; for example, in tty.cc (reformatted slightly):
>
>  if (wincap.has_security ()
>       && cygserver_running==CYGSERVER_OK
>       && (SetKernelObjectSecurity (hMainProc,
>            ACL_SECURITY_INFORMATION,
>            get_null_sd ()) == FALSE))
>    small_printf ("Can't set process security, %E");
>
>Would a patch to change (all of?) these uses to system_printf be
>accepted?

I only see a couple of these that I think should be changed.  I checked
in a fix to eliminate them.

Thanks for the heads up.

cgf



More information about the Cygwin-developers mailing list