change to fhandler_console.cc from 2001-10-23 breaks ttyfier

Christopher Faylor cgf@redhat.com
Thu Nov 1 03:21:00 GMT 2001


On Mon, Nov 12, 2001 at 05:11:54PM +0300, egor duda wrote:
>Hi!
>
>2001-10-23  Christopher Faylor  <cgf@redhat.com>
>
>        * fhandler_console.cc (fhandler_console::read): Remove unneeded test.
>        Only honor "key down" events.
>
>this change breaks ttyfier. unfortunately some programs (notably
>ntvdm) want to see key-up events. without them they think that ctrl
>key is stuck.
>
>key-up events should work only in raw mode -- there's a check for
>key-down flag in fhandler_console.cc:291
>
>what was the reason of this change?

I saw a similar change in Ian Ray's Win95 CAPS-lock fix and wondered if it
would solve any problems on w95.  It doesn't.

I'll revert the change.

cgf



More information about the Cygwin-developers mailing list