This is the mail archive of the cygwin-developers@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: hierarchy in setup (category stuff)


Actually,that part of my patch is broken - I haven't updated the logging
in some time. Both dependencies and categories should be logged, and
pkg->category is not necessarily a string :].

For now, I'd just remove the category from that line altogether.

Rob

----- Original Message -----
From: "Michael A. Chase" <mchase@ix.netcom.com>
To: "Robert Collins" <robert.collins@itdomain.com.au>;
<cygwin-developers@sources.redhat.com>
Sent: Sunday, June 24, 2001 10:35 PM
Subject: Re: hierarchy in setup (category stuff)


> I'd like to suggest a minor format change in part of your patch:
>
>       log (LOG_BABBLE, "[%s] action=%s trust=%s installed=%s
excluded=%s"
>     " src?=%s category=%s",
>       pkg->name, action, trust, installed, excluded,
>      pkg->srcpicked ? "yes" : "no", pkg->category);
>
> This adds a space before "category" and makes the first line less than
80
> characters long.
>
> I've been compiling and running setup.exe with both our patches
applied.  I
> had to hand apply 4 hunks in choose.cc, but they were fairly simple.
> Applying my patch after yours is more complicated, so if mine is
approved,
> I'll send you a patch for choose.cc to resolve the differences from
your
> latest hierarchy patch.
> --
> Mac :})
> Give a hobbit a fish and he eats fish for a day.
> Give a hobbit a ring and he eats fish for an age.
>
>
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]