Re: cygwin-src-20000125: patch to not convert cmdline to OEM

[Reinhard Nissl <rnissl at gmx dot de>]

Hi,

I'm sorry for this late reply. I first thought, that I don't receive any mails
from this list, but today, I found the cause of this problem: a misconfigured
mail filter took all mails from this list into a folder, I don't lookup very
often :-(

Well, I'm willing to solve the issues mentioned. But first of all, I'd like to
know, whether there have been some changes already, as Corinna wrote.

Concerning issue 1 (if it is still necessary):
"It's using a non-standard environment variable to control this behavior."

Should I use a different (already existing) one, or should I only change the
name? Well, I'm not used to the naming scheme, CYGWIN uses for environment
variables, so I'd thankfully accept any suggestions for the variable name.

Thanks for your replies so far, next I'll be downloading a current snapshot to
create a new patch.

Bye.



Corinna Vinschen wrote:
> 
> Chris Faylor wrote:
> > On Sun, Feb 13, 2000 at 05:50:33PM +0100, Reinhard Nissl wrote:
> > >the attached patch makes cygwin1.dll only convert the cmdline to OEM when the
> > >environment variable CYGWIN_CMD_LINE_MODE is not set to ANSI. If the variable
> > >doesn't exist or is set to anything else then ANSI, the library behaves as it
> > >did before applying the patch.
> > > [...]
> > I have a few problems with this patch.
> > [...]
> > 4) I am wondering if the conditional behavior of this code should actually be
> >    the default behavior, i.e., should we always be using SetFileApisToANSI and
> >    MultiByteToWideChar.
> >
> > 1 - 3 are obviously easy to fix but I'd like to get a better feel for 3.
> > Can some other non-US people comment on this patch?
> 
> In telnet or xterm this shouldn't be a problem.
> 
> But isn't it needed to set the corresponding codepage e.g. 1252
> (ANSI Latin 1) instead of 850 (OEM Latin 1) if using ANSI in console
> window?
> 
> I would suggest to try ANSI as default behaviour in the developer
> snapshots in the next time. It's easy to revert if we got problems.
> 
> Hmm, possibly we should try it _after_ the next net release?!?
> 
> Corinna
--
Dipl.-Inform. (FH) Reinhard Nissl
mailto:rnissl@gmx.de